[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 2 15:22:06 PDT 2025


================
@@ -1137,9 +1132,18 @@ class StopInfoUnixSignal : public StopInfo {
     return m_description.c_str();
   }
 
+  bool ShouldSelect() const override { return IsShouldStopSignal(); }
+
 private:
   // In siginfo_t terms, if m_value is si_signo, m_code is si_code.
   std::optional<int> m_code;
+
+  bool IsShouldStopSignal() const {
+    ThreadSP thread_sp(m_thread_wp.lock());
+    if (thread_sp)
+      return thread_sp->GetProcess()->GetUnixSignals()->GetShouldStop(m_value);
----------------
JDevlieghere wrote:

```suggestion
    ThreadSP thread_sp(m_thread_wp.lock());
    if (ThreadSP thread_sp = m_thread_wp.lock())
      return thread_sp->GetProcess()->GetUnixSignals()->GetShouldStop(m_value);
```

https://github.com/llvm/llvm-project/pull/134160


More information about the lldb-commits mailing list