[Lldb-commits] [lldb] [lldb-dap] Creating a common configuration structure for launch and attach requests. (PR #133960)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 1 21:33:51 PDT 2025
================
@@ -118,6 +118,81 @@ bool fromJSON(const llvm::json::Value &, InitializeRequestArguments &,
/// Response to `initialize` request. The capabilities of this debug adapter.
using InitializeResponseBody = std::optional<Capabilities>;
+/// DAP Launch and Attach common configurations.
+struct DAPConfiguration {
----------------
JDevlieghere wrote:
Nit: Any reason to not call this `Configuration`? We don't prefix everything else here with `DAP` and it's already in the `dap::protocol` namespace.
```suggestion
struct Configuration {
```
https://github.com/llvm/llvm-project/pull/133960
More information about the lldb-commits
mailing list