[Lldb-commits] [lldb] Fix handling of auto_continue for stop hooks (PR #129622)
via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 1 15:18:49 PDT 2025
================
@@ -3109,7 +3104,10 @@ bool Target::RunStopHooks() {
auto result = cur_hook_sp->HandleStop(exc_ctx, output_sp);
switch (result) {
case StopHook::StopHookResult::KeepStopped:
----------------
jimingham wrote:
Only KeepStopped. If any thread reports AlreadyContinued, then we aren't doing this negotiation anymore, someone called `continue` directly. Threads reporting NoPreference shouldn't be consulted here. And RequestContinue means that thread goes along with continuing.
GetAutoContinue is formally different, since that is a stop-hook that's asking to auto-continue regardless of what value it returns from the stop hook callback, but in practice is the same as RequestContinue.
https://github.com/llvm/llvm-project/pull/129622
More information about the lldb-commits
mailing list