[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

[Vy Nguyen via lldb-commits]

================
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() {
   return sb_target;
 }
 
+void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) {
+  LLDB_INSTRUMENT_VA(this);
+  // Disable client-telemetry for SWIG.
+  // This prevent arbitrary python client (pretty printers, whatnot) from sending
+  // telemetry without vendors knowing.
+#ifndef SWIG
----------------
oontvoo wrote:

Ok, I've defined a ENABLE_CLIENT_TELEMETRY macro at the top of SBDebugger and use the ifdef with it.
(It's currently hard-coded to `! SWIG` , might be overkill to make that a build option? )

https://github.com/llvm/llvm-project/pull/129728