[Lldb-commits] [lldb] 2a96bec - [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (#133309)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Mar 27 14:20:47 PDT 2025
Author: Jacob Lalonde
Date: 2025-03-27T14:20:43-07:00
New Revision: 2a96beca9b502776d5e2a3be2da3f886135b056e
URL: https://github.com/llvm/llvm-project/commit/2a96beca9b502776d5e2a3be2da3f886135b056e
DIFF: https://github.com/llvm/llvm-project/commit/2a96beca9b502776d5e2a3be2da3f886135b056e.diff
LOG: [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (#133309)
In the original SBProgress patch, #123837, I didn't ensure the debugger
was broadcasting these events to the CLI as SBProgress has far been
focused on DAP. We had an internal ask to have SBProgress events
broadcasted to the CLI so this patch addresses that.
<img width="387" alt="image"
src="https://github.com/user-attachments/assets/5eb93a46-1db6-4d46-a6b7-2b2f9bbe71db"
/>
Added:
Modified:
lldb/source/Core/Debugger.cpp
Removed:
################################################################################
diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp
index 993aa2d970de6..ec7f841320217 100644
--- a/lldb/source/Core/Debugger.cpp
+++ b/lldb/source/Core/Debugger.cpp
@@ -2076,7 +2076,8 @@ lldb::thread_result_t Debugger::DefaultEventHandler() {
}
}
} else if (broadcaster == &m_broadcaster) {
- if (event_type & lldb::eBroadcastBitProgress)
+ if (event_type & lldb::eBroadcastBitProgress ||
+ event_type & lldb::eBroadcastBitExternalProgress)
HandleProgressEvent(event_sp);
else if (event_type & lldb::eBroadcastBitWarning)
HandleDiagnosticEvent(event_sp);
More information about the lldb-commits
mailing list