[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 27 13:21:24 PDT 2025


https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/133309

In the original SBProgress patch, #123837, I didn't ensure the debugger was broadcasting these events to the CLI. This patch addresses that.

<img width="387" alt="image" src="https://github.com/user-attachments/assets/5eb93a46-1db6-4d46-a6b7-2b2f9bbe71db" />


>From d5840447a35992530963ae910615b1908e2880d2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde <jalalonde at fb.com>
Date: Thu, 27 Mar 2025 13:15:46 -0700
Subject: [PATCH] Configure sbprogress events to be emitted for the CLI

---
 lldb/source/Core/Debugger.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp
index 8c705f889983a..cf247974ad966 100644
--- a/lldb/source/Core/Debugger.cpp
+++ b/lldb/source/Core/Debugger.cpp
@@ -2024,7 +2024,7 @@ lldb::thread_result_t Debugger::DefaultEventHandler() {
               }
             }
           } else if (broadcaster == &m_broadcaster) {
-            if (event_type & lldb::eBroadcastBitProgress)
+            if (event_type & lldb::eBroadcastBitProgress || event_type & lldb::eBroadcastBitExternalProgress)
               HandleProgressEvent(event_sp);
             else if (event_type & lldb::eBroadcastBitWarning)
               HandleDiagnosticEvent(event_sp);



More information about the lldb-commits mailing list