[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs (PR #132370)

[Michael Buch via lldb-commits]

Michael137 wrote:

Still double checking but i think this may have broken a couple of macOS x86_64 tests: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/10909/


```
TestTsanMultiple.test_dsym/a.out")

runCmd: env TSAN_OPTIONS=abort_on_error=0

output: 

runCmd: run

warning: libclang_rt.tsan_osx_dynamic.dylib was compiled with optimization - stepping may behave oddly; variables may not be available.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  liblldb.21.0.99git.dylib 0x000000011c97b778 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 40
1  liblldb.21.0.99git.dylib 0x000000011c979789 llvm::sys::RunSignalHandlers() + 233
2  liblldb.21.0.99git.dylib 0x000000011c97bdd6 SignalHandler(int, __siginfo*, void*) + 278
3  libsystem_platform.dylib 0x00007ff80b4d0e9d _sigtramp + 29
4  libsystem_platform.dylib 0x0000700007db4860 _sigtramp + 18446726515825457632
5  liblldb.21.0.99git.dylib 0x0000000118618347 lldb_private::x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite(unsigned char*, unsigned long, lldb_private::AddressRange&, lldb_private::UnwindPlan&, std::__1::shared_ptr<lldb_private::RegisterContext>&) + 919
6  liblldb.21.0.99git.dylib 0x0000000118614045 UnwindAssembly_x86::AugmentUnwindPlanFromCallSite(lldb_private::AddressRange&, lldb_private::Thread&, lldb_private::UnwindPlan&) + 997
7  liblldb.21.0.99git.dylib 0x0000000119819113 lldb_private::FuncUnwinders::GetEHFrameAugmentedUnwindPlan(lldb_private::Target&, lldb_private::Thread&) + 387
8  liblldb.21.0.99git.dylib 0x0000000119819ace lldb_private::FuncUnwinders::GetUnwindPlanAtNonCallSite(lldb_private::Target&, lldb_private::Thread&) + 446
9  liblldb.21.0.99git.dylib 0x0000000119898102 lldb_private::RegisterContextUnwind::GetFullUnwindPlanForFrame() + 2978
10 liblldb.21.0.99git.dylib 0x00000001198952a7 lldb_private::RegisterContextUnwind::InitializeZerothFrame() + 1383
11 liblldb.21.0.99git.dylib 0x0000000119896e23 lldb_private::RegisterContextUnwind::RegisterContextUnwind(lldb_private::Thread&, std::__1::shared_ptr<lldb_private::RegisterContextUnwind> const&, lldb_private::SymbolContext&, unsigned int, lldb_private::UnwindLLDB&) + 243
12 liblldb.21.0.99git.dylib
...
```

https://github.com/llvm/llvm-project/pull/132370