[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

[Jonas Devlieghere via lldb-commits]

================
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() {
   return sb_target;
 }
 
+void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) {
+  LLDB_INSTRUMENT_VA(this);
+  // Disable client-telemetry for SWIG.
+  // This prevent arbitrary python client (pretty printers, whatnot) from sending
+  // telemetry without vendors knowing.
+#ifndef SWIG
----------------
JDevlieghere wrote:

I think the `ifndef` should go in the header and guard the whole function so it's not expose from SWIG. That said, downstream I will replace it with an `#if 0` or just remove this method altogether because I don't want anyone external to LLDB to call this. 

https://github.com/llvm/llvm-project/pull/129728