[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

I follow the argument about a custom iterator likely being more complicated, but the callbacks aren't much better in that regard. Did you consider having something like `GetEnabledInstances` that returns a vector with just the enabled instances? It seems like that would be a lot less intrusive and I'd be surprised if this code is hot enough that the overhead of creating a new vector instead of returning a reference makes a difference. 

https://github.com/llvm/llvm-project/pull/132884