[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 26 09:47:24 PDT 2025


================
@@ -936,3 +936,7 @@ size_t StackFrameList::GetStatus(Stream &strm, uint32_t first_frame,
   strm.IndentLess();
   return num_frames_displayed;
 }
+
+void StackFrameList::ClearSelectedFrameIndex() {
----------------
Michael137 wrote:

hmmmm good question. `GetSelectedFrameIndex` is not taking the mutex either. On first glance I would've thought the mutex is there to just protect the `m_frames`. There's a separate `m_inlined_depth_mutex` that protects the corresponding member (for performance reason based on the comment next to it).

But if `ClearSelectedFrameIndex` and `GetSelectedFrameIndex` they should be protected against concurrent access. Do we have concerns with using the list mutex for that?

https://github.com/llvm/llvm-project/pull/133078


More information about the lldb-commits mailing list