[Lldb-commits] [lldb] [lldb][Instrumentation] GetPreferredAsanModule should be no-op on non-Darwin platforms (PR #132911)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Michael Buch (Michael137)

<details>
<summary>Changes</summary>

The regex we use to find the compiler-rt library is already Darwin-specific, so no need to run this on non-Darwin platforms.

---
Full diff: https://github.com/llvm/llvm-project/pull/132911.diff


1 Files Affected:

- (modified) lldb/source/Plugins/InstrumentationRuntime/Utility/Utility.cpp (+4) 


``````````diff
diff --git a/lldb/source/Plugins/InstrumentationRuntime/Utility/Utility.cpp b/lldb/source/Plugins/InstrumentationRuntime/Utility/Utility.cpp
index 3cbd03b24297a..0f69a5e9e57c8 100644
--- a/lldb/source/Plugins/InstrumentationRuntime/Utility/Utility.cpp
+++ b/lldb/source/Plugins/InstrumentationRuntime/Utility/Utility.cpp
@@ -18,6 +18,10 @@ namespace lldb_private {
 ///< This helper searches the target for such a dylib. Returns nullptr if no
 ///< such dylib was found.
 lldb::ModuleSP GetPreferredAsanModule(const Target &target) {
+  // Currently only supported on Darwin.
+  if (!target.GetArchitecture().GetTriple().isOSDarwin())
+    return nullptr;
+
   lldb::ModuleSP module;
   llvm::Regex pattern(R"(libclang_rt\.asan_.*_dynamic\.dylib)");
   target.GetImages().ForEach([&](const lldb::ModuleSP &m) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/132911