[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

[Jordan Rupprecht via lldb-commits]

rupprecht wrote:

Still seeing a crash even with the latest fix applied
```
assertion failed at clang/include/clang/AST/Type.h:945 in const ExtQualsTypeCommonBase *clang::QualType::getCommonPtr() const: !isNull() && "Cannot retrieve a NULL type pointer"
*** Check failure stack trace: ***
    @     0x55e0dffed1f5  DeduceTemplateArgumentsByTypeMatch()
    @     0x55e0dffecc3e  DeduceTemplateArgumentsByTypeMatch()
    @     0x55e0dfff79f1  DeduceTemplateArguments()
    @     0x55e0dffe3ce9  DeduceTemplateArguments()
    @     0x55e0dffe47c0  clang::Sema::DeduceTemplateArguments()
    @     0x55e0e008943b  clang::Sema::InstantiateClassTemplateSpecialization()
    @     0x55e0e018b8a3  llvm::function_ref<>::callback_fn<>()
    @     0x55e0e0b04caf  clang::StackExhaustionHandler::runWithSufficientStackSpace()
    @     0x55e0e01741a8  clang::Sema::RequireCompleteTypeImpl()
    @     0x55e0e01739b5  clang::Sema::RequireCompleteType()
    @     0x55e0df8e6914  clang::Sema::RequireCompleteDeclContext()
    @     0x55e0dfd44fa9  clang::Sema::LookupParsedName()
    @     0x55e0dfb3b113  clang::Sema::BuildQualifiedDeclarationNameExpr()
    @     0x55e0e00d83e8  clang::TreeTransform<>::TransformDependentScopeDeclRefExpr()
    @     0x55e0e00d2529  clang::TreeTransform<>::TransformCallExpr()
    @     0x55e0e00ef218  clang::TreeTransform<>::TransformReturnStmt()
    @     0x55e0e00d9018  clang::TreeTransform<>::TransformCompoundStmt()
    @     0x55e0e008aa0a  clang::Sema::SubstStmt()
    @     0x55e0e011f3ce  clang::Sema::InstantiateFunctionDefinition()
    @     0x55e0e0b04caf  clang::StackExhaustionHandler::runWithSufficientStackSpace()
    @     0x55e0dffed9d6  clang::Sema::DeduceReturnType()
    @     0x55e0dfb2bac5  clang::Sema::DiagnoseUseOfDecl()
    @     0x55e0dfeb8361  FinishOverloadedCallExpr()
    @     0x55e0dfeb8274  clang::Sema::BuildOverloadedCallExpr()
    @     0x55e0dfb322ba  clang::Sema::BuildCallExpr()
    @     0x55e0dfb492b8  clang::Sema::ActOnCallExpr()
    @     0x55e0e00d2704  clang::TreeTransform<>::TransformCallExpr()
    @     0x55e0e008d052  clang::TreeTransform<>::TransformExprs()
    @     0x55e0e00d258c  clang::TreeTransform<>::TransformCallExpr()
    @     0x55e0e008d052  clang::TreeTransform<>::TransformExprs()
    @     0x55e0e00d258c  clang::TreeTransform<>::TransformCallExpr()
    @     0x55e0e00ef218  clang::TreeTransform<>::TransformReturnStmt()
    @     0x55e0e00d9018  clang::TreeTransform<>::TransformCompoundStmt()
    @     0x55e0e008aa0a  clang::Sema::SubstStmt()
    @     0x55e0e011f3ce  clang::Sema::InstantiateFunctionDefinition()
    @     0x55e0e01227ba  clang::Sema::PerformPendingInstantiations()
    @     0x55e0df88aaac  clang::Sema::ActOnEndOfTranslationUnitFragment()
    @     0x55e0df88b22b  clang::Sema::ActOnEndOfTranslationUnit()
    @     0x55e0df5a1e5a  clang::Parser::ParseTopLevelDecl()
    @     0x55e0df59e05e  clang::ParseAST()
...
```
In the meantime, I'll try reducing this

https://github.com/llvm/llvm-project/pull/132401