[Lldb-commits] [lldb] [lldb] Fix missing overloads in ThreadMemory (PR #132734)

via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 24 14:11:25 PDT 2025


================
@@ -79,34 +136,124 @@ class ThreadMemory : public lldb_private::Thread {
   }
 
   bool SetBackingThread(const lldb::ThreadSP &thread_sp) override {
-    // printf ("Thread 0x%llx is being backed by thread 0x%llx\n", GetID(),
-    // thread_sp->GetID());
     m_backing_thread_sp = thread_sp;
     thread_sp->SetBackedThread(*this);
-    return (bool)thread_sp;
+    return thread_sp.get();
   }
 
   lldb::ThreadSP GetBackingThread() const override {
     return m_backing_thread_sp;
   }
 
-protected:
   bool IsOperatingSystemPluginThread() const override { return true; }
 
-  // If this memory thread is actually represented by a thread from the
-  // lldb_private::Process subclass, then fill in the thread here and
-  // all APIs will be routed through this thread object. If m_backing_thread_sp
-  // is empty, then this thread is simply in memory with no representation
-  // through the process plug-in.
+private:
+  lldb::addr_t m_register_data_addr;
   lldb::ThreadSP m_backing_thread_sp;
-  lldb::ValueObjectSP m_thread_info_valobj_sp;
+
+  ThreadMemory(const ThreadMemory &) = delete;
+  const ThreadMemory &operator=(const ThreadMemory &) = delete;
+};
+
----------------
jimingham wrote:

Should have a comment mirroring the ProvidingNameAndQueue

https://github.com/llvm/llvm-project/pull/132734


More information about the lldb-commits mailing list