[Lldb-commits] [lldb] [lldb][NFC] use platform independent path separator in testSettings.py. (PR #132392)

[Ebuka Ezike via lldb-commits]

https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/132392

>From 493a5798524361442ab19be4b0a8077910984ffc Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Fri, 21 Mar 2025 13:04:29 +0000
Subject: [PATCH 1/2] [lldb][NFC] use platform independent path separator.

The build bot was failing when connecting from windows to linux.

Signed-off-by: Ebuka Ezike <yerimyah1 at gmail.com>
---
 lldb/test/API/commands/settings/TestSettings.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lldb/test/API/commands/settings/TestSettings.py b/lldb/test/API/commands/settings/TestSettings.py
index 6b89ff76a2900..045b93dab2e2a 100644
--- a/lldb/test/API/commands/settings/TestSettings.py
+++ b/lldb/test/API/commands/settings/TestSettings.py
@@ -1018,7 +1018,9 @@ def test_settings_api(self):
 
         # Test OptionValueFileSpec and OptionValueFileSpecList
         setting_path = "target.debug-file-search-paths"
-        setting_value = ["/tmp" "/tmp2"]
+        path1 = os.path.join(self.getSourceDir(), "tmp")
+        path2 = os.path.join(self.getSourceDir(), "tmp2")
+        setting_value = [path1, path2]
         self.runCmd("settings set %s %s" % (setting_path, " ".join(setting_value)))
         settings_json = self.get_setting_json(setting_path)
         self.assertEqual(settings_json, setting_value)

>From 10f60e72b27c649981225401121b58d879ca9c69 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Fri, 21 Mar 2025 13:24:42 +0000
Subject: [PATCH 2/2] Update lldb/test/API/commands/settings/TestSettings.py

Add quotes around variables

Co-authored-by: Pavel Labath <pavel at labath.sk>
---
 lldb/test/API/commands/settings/TestSettings.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lldb/test/API/commands/settings/TestSettings.py b/lldb/test/API/commands/settings/TestSettings.py
index 045b93dab2e2a..2a7c852fc916d 100644
--- a/lldb/test/API/commands/settings/TestSettings.py
+++ b/lldb/test/API/commands/settings/TestSettings.py
@@ -1020,8 +1020,7 @@ def test_settings_api(self):
         setting_path = "target.debug-file-search-paths"
         path1 = os.path.join(self.getSourceDir(), "tmp")
         path2 = os.path.join(self.getSourceDir(), "tmp2")
-        setting_value = [path1, path2]
-        self.runCmd("settings set %s %s" % (setting_path, " ".join(setting_value)))
+        self.runCmd("settings set %s '%s' '%s'" % (setting_path, path1, path2))
         settings_json = self.get_setting_json(setting_path)
         self.assertEqual(settings_json, setting_value)