[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

[via lldb-commits]

jimingham wrote:



> On Mar 20, 2025, at 1:47 AM, Pavel Labath ***@***.***> wrote:
> 
> 
> labath
>  left a comment 
> (llvm/llvm-project#129092)
> So having a way to indicate you need the faster vrs. the more bullet-proof behavior might be an acceptable solution. You might even argue that the setting should be "bullet-proof behavior" by default. If you are shipping a data formatter that benefits from this setting, you can also set the setting in the module that installs the data formatters...
> 
> Or make it an expression flag that can be set (in SBExpressionOptions) on expressions that you know are safe.
> 
>  <https://github.com/llvm/llvm-project/pull/129092#issuecomment-2739612203> <https://github.com/notifications/unsubscribe-auth/ADUPVW3GXGYL53DSBSA5ZET2VJ6CXAVCNFSM6AAAAABYAO4MDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZZGYYTEMRQGM>
> 
> labath
>  left a comment 
> (llvm/llvm-project#129092)
>  <https://github.com/llvm/llvm-project/pull/129092#issuecomment-2739612203>
> So having a way to indicate you need the faster vrs. the more bullet-proof behavior might be an acceptable solution. You might even argue that the setting should be "bullet-proof behavior" by default. If you are shipping a data formatter that benefits from this setting, you can also set the setting in the module that installs the data formatters...
> 
> Or make it an expression flag that can be set (in SBExpressionOptions) on expressions that you know are safe.
> 
Yes, that's certainly a better way to do it, since then we can make the default in SBExpressionOptions be "bullet-proof" and fast behavior can be dialed up in the formatter without having to touch generic state.

Jim

> (But generally yes, it's better (and faster) to avoid expression evaluation altogether. I don't know how many data formatters are you dealing with, but I would recommend changing them to not do that.)
> 
> —
> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/129092#issuecomment-2739612203>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW3GXGYL53DSBSA5ZET2VJ6CXAVCNFSM6AAAAABYAO4MDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZZGYYTEMRQGM>.
> You are receiving this because you are on a team that was mentioned.
> 



https://github.com/llvm/llvm-project/pull/129092