[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

[Jonas Devlieghere via lldb-commits]

================
@@ -0,0 +1,55 @@
+//===-- CancelRequestHandler.cpp ------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "Handler/RequestHandler.h"
+#include "Protocol/ProtocolRequests.h"
+#include "llvm/Support/Error.h"
+
+using namespace lldb_dap;
+using namespace lldb_dap::protocol;
+
+namespace lldb_dap {
+
+/// The `cancel` request is used by the client in two situations:
+///
+/// - to indicate that it is no longer interested in the result produced by a
+/// specific request issued earlier
+/// - to cancel a progress sequence.
+///
+/// Clients should only call this request if the corresponding capability
----------------
JDevlieghere wrote:

The documentation contains some wording with recommendations (i.e. "should"). Do we expect clients to read this? Is this coming from the DAP documentation? Otherwise it seems like this should be aimed at us, server implementers. 

https://github.com/llvm/llvm-project/pull/130169