[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

[Pavel Labath via lldb-commits]

labath wrote:

> Should we perhaps skip this on intel+macOS?

861efd4b3f93d30d353f0a6eea249fbdac1778a0



> Maybe disabling tests for macOS < 15 would be OK even in the long term? There isn't any looming plan to actually use this code on macOS < 15. The main reason to run these tests on non-Linux is so to help developers catch it early if they break these tests. I guess most developers on Mac will be doing most of their testing on 15 or later?

Maybe? I think it'd be nice to fix the x86 problem at least, which appears to be because  debugserver reports some registers that its unable to read (`ds` at least). It'd be better if it didn't do that, but I think it'd make sense for the proxy to not fail on these errors (it could e.g. record the error it gets when reading the register, and forward it if lldb asks for it, but then skip restoring the state of the register).

As for the macOS 14 case, while I think it be nice to support that as well (I don't quite like the fact that the test is running on any of the bots, and it feels like we're very close to making that work), I think you've already done a lot more to make your tests run on platforms you aren't targetting than what other patches do, so it wouldn't be fair to expect you do to that.

https://github.com/llvm/llvm-project/pull/128156