[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 14 14:33:23 PDT 2025


================
@@ -969,12 +969,89 @@ Status MinidumpFileBuilder::DumpDirectories() const {
   return error;
 }
 
-static uint64_t
-GetLargestRangeSize(const std::vector<CoreFileMemoryRange> &ranges) {
-  uint64_t max_size = 0;
-  for (const auto &core_range : ranges)
-    max_size = std::max(max_size, core_range.range.size());
-  return max_size;
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
----------------
Jlalond wrote:

Not opposed, but because this patch has been open for quite some time can I make that a follow up patch?

https://github.com/llvm/llvm-project/pull/129307


More information about the lldb-commits mailing list