[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

[Greg Clayton via lldb-commits]

================
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const {
   return error;
 }
 
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+    const std::unique_ptr<lldb_private::DataBufferHeap> &data_up,
----------------
clayborg wrote:

Change this to a `lldb_private::DataBufferHeap &data`. Unless we are doing something with the unique_ptr here that makes sense, there is no reason to use a unique pointer in the args.

https://github.com/llvm/llvm-project/pull/129307