[Lldb-commits] [lldb] Parallelize module loading in POSIX dyld code (PR #130912)

[Tom Yang via lldb-commits]

zhyty wrote:

> This looks like the equivalent of #110646 but for Linux and the overall approach looks good to me.
> 
> My only real concern is about the setting and it being **off** by default. I would prefer that this is **on** by default and the setting is there as an escape hatch in case there's an unexpected issue. I'd like to understand what's holding that back?
> 
> Building on that, if the setting is on by default, then instead of creating a new setting per plugin, I'd like to hoist it into target and have one setting that controls this behavior for all of them. I expect it to be rare that you'd want to turn this off for one plugin but not the other. Unless we are a 100% sure we're going to take away the setting (in which case the setting should be experimental[1]), it's easier to keep it around, for example to make it easier to debug or quickly toggle it and see if a concurrency issue disappears.
> 
> [1] See `plugin.dynamic-loader.darwin.experimental.enable-parallel-image-load`. The experimental prefix allows you to set that option without it existing for when it either gets promoted to a real setting (without the experimental) or alternative it goes away.

Thanks for the review.

Yes, this PR was inspired by #110646 (I didn't have the PR number on hand, will link in the description). 

Internally, we were planning to have it on by default as well, but we felt that maybe it would be easier to land in open source if we had it off by default. I'm in favor of having it on as well, having no known issues.

https://github.com/llvm/llvm-project/pull/130912