[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 14 04:01:04 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 77ad061923418ba0f4c8fd4a0710a5ace825bf8e 106e137fea7d4b420ce3d97a8df16c3a91400997 --extensions cpp -- lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp b/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
index 0dd9126468..eebf6a3a65 100644
--- a/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
+++ b/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
@@ -267,48 +267,48 @@ void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {
     }
   }
 }
-  void ObjectFileXCOFF::Dump(Stream * s) {}
+void ObjectFileXCOFF::Dump(Stream *s) {}
 
-  ArchSpec ObjectFileXCOFF::GetArchitecture() {
-    ArchSpec arch_spec =
-        ArchSpec(eArchTypeXCOFF, XCOFF::TCPU_PPC64, LLDB_INVALID_CPUTYPE);
-    return arch_spec;
-  }
+ArchSpec ObjectFileXCOFF::GetArchitecture() {
+  ArchSpec arch_spec =
+      ArchSpec(eArchTypeXCOFF, XCOFF::TCPU_PPC64, LLDB_INVALID_CPUTYPE);
+  return arch_spec;
+}
 
-  UUID ObjectFileXCOFF::GetUUID() { return UUID(); }
+UUID ObjectFileXCOFF::GetUUID() { return UUID(); }
 
-  uint32_t ObjectFileXCOFF::GetDependentModules(FileSpecList & files) {
-    return 0;
-  }
+uint32_t ObjectFileXCOFF::GetDependentModules(FileSpecList &files) { return 0; }
 
-  ObjectFile::Type ObjectFileXCOFF::CalculateType() {
-    if (m_binary->fileHeader64()->Flags & XCOFF::F_EXEC)
-      return eTypeExecutable;
-    else if (m_binary->fileHeader64()->Flags & XCOFF::F_SHROBJ)
-      return eTypeSharedLibrary;
-    return eTypeUnknown;
-  }
+ObjectFile::Type ObjectFileXCOFF::CalculateType() {
+  if (m_binary->fileHeader64()->Flags & XCOFF::F_EXEC)
+    return eTypeExecutable;
+  else if (m_binary->fileHeader64()->Flags & XCOFF::F_SHROBJ)
+    return eTypeSharedLibrary;
+  return eTypeUnknown;
+}
 
-  ObjectFile::Strata ObjectFileXCOFF::CalculateStrata() {
-    return eStrataUnknown;
-  }
+ObjectFile::Strata ObjectFileXCOFF::CalculateStrata() { return eStrataUnknown; }
 
-  lldb::WritableDataBufferSP ObjectFileXCOFF::MapFileDataWritable(
-      const FileSpec &file, uint64_t Size, uint64_t Offset) {
-    return FileSystem::Instance().CreateWritableDataBuffer(file.GetPath(), Size,
-                                                           Offset);
-  }
+lldb::WritableDataBufferSP
+ObjectFileXCOFF::MapFileDataWritable(const FileSpec &file, uint64_t Size,
+                                     uint64_t Offset) {
+  return FileSystem::Instance().CreateWritableDataBuffer(file.GetPath(), Size,
+                                                         Offset);
+}
 
-  ObjectFileXCOFF::ObjectFileXCOFF(
-      const lldb::ModuleSP &module_sp, DataBufferSP data_sp,
-      lldb::offset_t data_offset, const FileSpec *file,
-      lldb::offset_t file_offset, lldb::offset_t length)
-      : ObjectFile(module_sp, file, file_offset, length, data_sp, data_offset) {
-    if (file)
-      m_file = *file;
-  }
+ObjectFileXCOFF::ObjectFileXCOFF(const lldb::ModuleSP &module_sp,
+                                 DataBufferSP data_sp,
+                                 lldb::offset_t data_offset,
+                                 const FileSpec *file,
+                                 lldb::offset_t file_offset,
+                                 lldb::offset_t length)
+    : ObjectFile(module_sp, file, file_offset, length, data_sp, data_offset) {
+  if (file)
+    m_file = *file;
+}
 
-  ObjectFileXCOFF::ObjectFileXCOFF(
-      const lldb::ModuleSP &module_sp, DataBufferSP header_data_sp,
-      const lldb::ProcessSP &process_sp, addr_t header_addr)
-      : ObjectFile(module_sp, process_sp, header_addr, header_data_sp) {}
+ObjectFileXCOFF::ObjectFileXCOFF(const lldb::ModuleSP &module_sp,
+                                 DataBufferSP header_data_sp,
+                                 const lldb::ProcessSP &process_sp,
+                                 addr_t header_addr)
+    : ObjectFile(module_sp, process_sp, header_addr, header_data_sp) {}

``````````

</details>


https://github.com/llvm/llvm-project/pull/131304


More information about the lldb-commits mailing list