[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)
John Harrison via lldb-commits
lldb-commits at lists.llvm.org
Thu Mar 13 09:45:25 PDT 2025
ashgti wrote:
> What is your overall plan for this PR?
>
> I assume the first step is to get buy-in from all reviewers into the new structure for our JSON types. But what comes after? Are you planning to update this PR to cover all JSON types / requests / responses? Are you planning to land this PR for the `Source*` types only (as currently in review) and do the remaining types in follow-up PRs?
>
> (Both approaches would be fine by me. Just trying to understand the approach, so I know when it's time to hit the "Approve" button 😉)
I was thinking of doing this more incrementally. I was planning to build on this for handling the 'cancel' request first but then I'd like to follow up with requests to use the new explicit types for handling arguments and responses.
https://github.com/llvm/llvm-project/pull/130090
More information about the lldb-commits
mailing list