[Lldb-commits] [lldb] [lldb] Split TestGdbRemoteFork test to avoid timeout (PR #129614)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 11 01:55:37 PDT 2025


labath wrote:

> > The test really is big and splitting it up is a good idea, but instead of an arbitrary 1/2/3 split, I think it be better to do it by functionality. Looking at the part of the code you moved, I can see several "themes" that we could use to split this up. One of them is "memory operations" (TestGdbRemoteMemory?) where we could put all of the memory and qMemoryRegionInfo tests. Another might be "qSupported" tests. And a third test for the register operations (`p`/`P` packets).
> > If that doesn't reduce the file sufficiently, I'm sure we can find some more.
> 
> Thanks for the suggestion. I wasn't familiar enough to do a proper split, but I can take a look based on your suggestion. It seems we already have some memory tests split out:
> 
> https://github.com/llvm/llvm-project/blob/main/lldb/test/API/tools/lldb-server/memory-allocation/TestGdbRemoteMemoryAllocation.py

Sounds good. And if you do that, then we can also create another/simpler binary for those tests. For example, all of the qSupported tests don't really care about the binary they're running. They just need *a* binary. It might as well just be `int main(){}`.

https://github.com/llvm/llvm-project/pull/129614


More information about the lldb-commits mailing list