[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

[Teresa Johnson via lldb-commits]

teresajohnson wrote:

@anjenner are you looking at the remaining reported buildbot failures? E.g. the unit testing failure below. Please fix or revert this change.

> LLVM Buildbot has detected a new failure on builder `llvm-nvptx-nvidia-ubuntu` running on `as-builder-7` while building `lldb,llvm` at step 6 "test-build-unified-tree-check-llvm".
> 
> Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/14226
> 
> Here is the relevant piece of the build log for the reference
> ```
> Step 6 (test-build-unified-tree-check-llvm) failure: test (failure)
> ******************** TEST 'LLVM-Unit :: Support/./SupportTests/134/175' FAILED ********************
> Script(shard):
> --
> GTEST_OUTPUT=json:/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/build/unittests/Support/./SupportTests-LLVM-Unit-1311025-134-175.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=175 GTEST_SHARD_INDEX=134 /home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/build/unittests/Support/./SupportTests
> --
> 
> Script:
> --
> /home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/build/unittests/Support/./SupportTests --gtest_filter=Caching.Normal
> --
> /home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/Support/Caching.cpp:55: Failure
> Value of: AddStream
>   Actual: false
> Expected: true
> 
> 
> /home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/Support/Caching.cpp:55
> Value of: AddStream
>   Actual: false
> Expected: true
> 
> 
> 
> ********************
> ```



https://github.com/llvm/llvm-project/pull/115331