[Lldb-commits] [lldb] [lldb-dap] Restore the override FD used by the output redirect on stop. (PR #129964)

Thu Mar 6 22:15:29 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/21306

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
97.117 [324/96/6785] Building CXX object tools/lldb/source/Plugins/SymbolFile/NativePDB/CMakeFiles/lldbPluginSymbolFileNativePDB.dir/PdbAstBuilder.cpp.o
97.120 [323/96/6786] Building CXX object tools/lldb/source/Plugins/SymbolFile/NativePDB/CMakeFiles/lldbPluginSymbolFileNativePDB.dir/PdbFPOProgramToDWARFExpression.cpp.o
97.127 [322/96/6787] Building CXX object tools/lldb/source/Plugins/SymbolFile/NativePDB/CMakeFiles/lldbPluginSymbolFileNativePDB.dir/PdbIndex.cpp.o
97.133 [321/96/6788] Building CXX object tools/lldb/source/Plugins/SymbolFile/NativePDB/CMakeFiles/lldbPluginSymbolFileNativePDB.dir/PdbSymUid.cpp.o
97.134 [320/96/6789] Building CXX object tools/lldb/source/Plugins/SymbolFile/NativePDB/CMakeFiles/lldbPluginSymbolFileNativePDB.dir/PdbUtil.cpp.o
97.135 [319/96/6790] Building CXX object tools/lldb/source/Plugins/SymbolFile/NativePDB/CMakeFiles/lldbPluginSymbolFileNativePDB.dir/SymbolFileNativePDB.cpp.o
97.137 [318/96/6791] Building CXX object tools/lldb/source/Plugins/SymbolFile/NativePDB/CMakeFiles/lldbPluginSymbolFileNativePDB.dir/UdtRecordCompleter.cpp.o
97.142 [317/96/6792] Building CXX object tools/lldb/source/Plugins/SymbolFile/PDB/CMakeFiles/lldbPluginSymbolFilePDB.dir/PDBLocationToDWARFExpression.cpp.o
97.150 [316/96/6793] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/LLDBUtils.cpp.o
97.152 [315/96/6794] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o
FAILED: tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/llvm-x86_64-debian-dylib/build/tools/lldb/tools/lldb-dap -I/b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/tools/lldb-dap -I/b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/include -I/b/1/llvm-x86_64-debian-dylib/build/tools/lldb/include -I/b/1/llvm-x86_64-debian-dylib/build/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/../clang/include -I/b/1/llvm-x86_64-debian-dylib/build/tools/lldb/../clang/include -isystem /usr/include/libxml2 -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-vla-extension -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o -MF tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o.d -o tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp.o -c /b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp
/b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp:59:7: error: use of undeclared identifier 'override'
  if (override) {
      ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/tools/lldb-dap/OutputRedirector.cpp:60:30: error: use of undeclared identifier 'override'
    int override_fd = fileno(override);
                             ^
2 errors generated.
97.153 [315/95/6795] Building CXX object tools/lldb/source/Plugins/SymbolFile/PDB/CMakeFiles/lldbPluginSymbolFilePDB.dir/PDBASTParser.cpp.o
97.155 [315/94/6796] Building CXX object tools/lldb/source/Plugins/SymbolFile/PDB/CMakeFiles/lldbPluginSymbolFilePDB.dir/SymbolFilePDB.cpp.o
97.155 [315/93/6797] Building CXX object tools/lldb/source/Plugins/SymbolFile/Symtab/CMakeFiles/lldbPluginSymbolFileSymtab.dir/SymbolFileSymtab.cpp.o
97.156 [315/92/6798] Building CXX object tools/lldb/source/Plugins/SystemRuntime/MacOSX/CMakeFiles/lldbPluginSystemRuntimeMacOSX.dir/AppleGetItemInfoHandler.cpp.o
97.157 [315/91/6799] Building CXX object tools/lldb/source/Plugins/SystemRuntime/MacOSX/CMakeFiles/lldbPluginSystemRuntimeMacOSX.dir/AppleGetPendingItemsHandler.cpp.o
97.158 [315/90/6800] Linking CXX static library lib/libclangDaemonTweaks.a
97.158 [315/89/6801] Linking CXX static library lib/libclangdMain.a
97.158 [315/88/6802] Linking CXX executable bin/dexp
97.159 [315/87/6803] Building CXX object tools/lldb/source/Plugins/SystemRuntime/MacOSX/CMakeFiles/lldbPluginSystemRuntimeMacOSX.dir/AppleGetQueuesHandler.cpp.o
97.160 [315/86/6804] Building CXX object tools/lldb/source/Plugins/SystemRuntime/MacOSX/CMakeFiles/lldbPluginSystemRuntimeMacOSX.dir/AppleGetThreadItemInfoHandler.cpp.o
97.161 [315/85/6805] Building CXX object tools/lldb/source/Plugins/SystemRuntime/MacOSX/CMakeFiles/lldbPluginSystemRuntimeMacOSX.dir/SystemRuntimeMacOSX.cpp.o
97.162 [315/84/6806] Building CXX object tools/lldb/source/Plugins/SystemRuntime/MacOSX/CMakeFiles/lldbPluginSystemRuntimeMacOSX.dir/AbortWithPayloadFrameRecognizer.cpp.o
97.162 [315/83/6807] Building CXX object tools/lldb/source/Plugins/SymbolLocator/Debuginfod/CMakeFiles/lldbPluginSymbolLocatorDebuginfod.dir/SymbolLocatorDebuginfod.cpp.o
97.163 [315/82/6808] Building CXX object tools/lldb/source/Plugins/SymbolLocator/Default/CMakeFiles/lldbPluginSymbolLocatorDefault.dir/SymbolLocatorDefault.cpp.o
97.164 [315/81/6809] Building CXX object tools/lldb/source/Plugins/SymbolVendor/ELF/CMakeFiles/lldbPluginSymbolVendorELF.dir/SymbolVendorELF.cpp.o
97.165 [315/80/6810] Building CXX object tools/lldb/source/Plugins/SymbolVendor/PECOFF/CMakeFiles/lldbPluginSymbolVendorPECOFF.dir/SymbolVendorPECOFF.cpp.o
97.165 [315/79/6811] Building CXX object tools/lldb/source/Plugins/SymbolVendor/wasm/CMakeFiles/lldbPluginSymbolVendorWasm.dir/SymbolVendorWasm.cpp.o
97.167 [315/78/6812] Building CXX object tools/lldb/source/Plugins/Trace/common/CMakeFiles/lldbPluginTraceCommon.dir/ThreadPostMortemTrace.cpp.o
97.168 [315/77/6813] Building CXX object tools/lldb/source/Plugins/TraceExporter/common/CMakeFiles/lldbPluginTraceExporterCommon.dir/TraceHTR.cpp.o
97.169 [315/76/6814] Building CXX object tools/lldb/source/Plugins/TraceExporter/ctf/CMakeFiles/lldbPluginTraceExporterCTF.dir/CommandObjectThreadTraceExportCTF.cpp.o
97.169 [315/75/6815] Building CXX object tools/lldb/source/Plugins/TraceExporter/ctf/CMakeFiles/lldbPluginTraceExporterCTF.dir/TraceExporterCTF.cpp.o
97.171 [315/74/6816] Building CXX object tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o
97.171 [315/73/6817] Building CXX object tools/lldb/source/Plugins/UnwindAssembly/InstEmulation/CMakeFiles/lldbPluginUnwindAssemblyInstEmulation.dir/UnwindAssemblyInstEmulation.cpp.o
97.172 [315/72/6818] Building CXX object tools/lldb/source/Plugins/UnwindAssembly/x86/CMakeFiles/lldbPluginUnwindAssemblyX86.dir/UnwindAssembly-x86.cpp.o
97.172 [315/71/6819] Building CXX object tools/lldb/source/Plugins/UnwindAssembly/x86/CMakeFiles/lldbPluginUnwindAssemblyX86.dir/x86AssemblyInspectionEngine.cpp.o
97.172 [315/70/6820] Building CXX object tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/ArmUnwindInfo.cpp.o
97.173 [315/69/6821] Building CXX object tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Block.cpp.o
97.173 [315/68/6822] Building CXX object tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/CompactUnwindInfo.cpp.o
97.174 [315/67/6823] Building CXX object tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/CompileUnit.cpp.o
97.175 [315/66/6824] Building CXX object tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/CompilerDecl.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/129964