[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)
Adrian Vogelsgesang via lldb-commits
lldb-commits at lists.llvm.org
Thu Mar 6 16:58:33 PST 2025
================
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined {
export class LLDBDapConfigurationProvider
implements vscode.DebugConfigurationProvider
{
+ resolveDebugConfiguration(
+ _folder: vscode.WorkspaceFolder | undefined,
+ debugConfiguration: vscode.DebugConfiguration,
+ _token?: vscode.CancellationToken,
+ ): vscode.ProviderResult<vscode.DebugConfiguration> {
+ // Default "pid" to ${command:pickProcess} if neither "pid" nor "program" are specified
+ // in an "attach" request.
+ if (
+ debugConfiguration.request === "attach" &&
+ !("pid" in debugConfiguration) &&
----------------
vogelsgesang wrote:
I think we should also use `pickProcess` in case the user provided a `program`. We will still show a quickpick in this case, but the quick-pick will be filtered down by the `program`
```suggestion
```
https://github.com/llvm/llvm-project/pull/128943
More information about the lldb-commits
mailing list