[Lldb-commits] [lldb] [lldb][Expression] Allow specifying a preferred ModuleList for lookup during expression evaluation (PR #129733)

[Michael Buch via lldb-commits]

Michael137 wrote:

> > > You should complete the module -> symbol_context mutatis mutandis. Other than that this seems like the right foundation for adding a user way to control the symbol lookups.
> > 
> > 
> > I kept the list of preferred contexts as a `ModuleList` in `IRExecutionUnit`. That's why I kept `Module` in the name where it applies. It made the implementation of the lookup easier (because `ModuleList` already has the symbol lookup APIs that we need). I discuss this a bit more in the PR description. Let me know what you think
> 
> Makes sense, the other searches happen earlier on in parsing, so that should be okay. But you still have in a couple of places:
> 
> void SetPreferredModules(SymbolContextList const &modules) {
> 
> And then it looks really weird when you iterate over `modules` and pull out `m.module_sp`???

sounds good, i renamed those in the latest commit

Let me know if i missed anything

https://github.com/llvm/llvm-project/pull/129733