[Lldb-commits] [lldb] 46236f4 - [lldb] Add missing type conversion for Windows

[Adrian Prantl via lldb-commits]

Author: Adrian Prantl
Date: 2025-03-05T12:58:22-08:00
New Revision: 46236f4c3dbe11e14fe7ac1f4b903637efedfecf

URL: https://github.com/llvm/llvm-project/commit/46236f4c3dbe11e14fe7ac1f4b903637efedfecf
DIFF: https://github.com/llvm/llvm-project/commit/46236f4c3dbe11e14fe7ac1f4b903637efedfecf.diff

LOG: [lldb] Add missing type conversion for Windows

Added: 
    

Modified: 
    lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp b/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
index 4379ffac9d744..858aecd1b9798 100644
--- a/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
+++ b/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
@@ -371,7 +371,7 @@ TEST_F(SymbolFilePDBTests, TestSimpleClassTypes) {
   CompilerType compiler_type = udt_type->GetForwardCompilerType();
   EXPECT_TRUE(TypeSystemClang::IsClassType(compiler_type.GetOpaqueQualType()));
   EXPECT_EQ(GetGlobalConstantInteger(session, "sizeof_Class"),
-            udt_type->GetByteSize(nullptr));
+            llvm::expectedToOptional(udt_type->GetByteSize(nullptr)));
 }
 
 TEST_F(SymbolFilePDBTests, TestNestedClassTypes) {
@@ -427,7 +427,7 @@ TEST_F(SymbolFilePDBTests, TestNestedClassTypes) {
   EXPECT_TRUE(TypeSystemClang::IsClassType(compiler_type.GetOpaqueQualType()));
 
   EXPECT_EQ(GetGlobalConstantInteger(session, "sizeof_NestedClass"),
-            udt_type->GetByteSize(nullptr));
+            llvm::expectedToOptional(udt_type->GetByteSize(nullptr)));
 }
 
 TEST_F(SymbolFilePDBTests, TestClassInNamespace) {
@@ -471,7 +471,7 @@ TEST_F(SymbolFilePDBTests, TestClassInNamespace) {
   EXPECT_TRUE(TypeSystemClang::IsClassType(compiler_type.GetOpaqueQualType()));
 
   EXPECT_EQ(GetGlobalConstantInteger(session, "sizeof_NSClass"),
-            udt_type->GetByteSize(nullptr));
+            llvm::expectedToOptional(udt_type->GetByteSize(nullptr)));
 }
 
 TEST_F(SymbolFilePDBTests, TestEnumTypes) {
@@ -501,7 +501,7 @@ TEST_F(SymbolFilePDBTests, TestEnumTypes) {
     std::string sizeof_var = "sizeof_";
     sizeof_var.append(Enum);
     EXPECT_EQ(GetGlobalConstantInteger(session, sizeof_var),
-              enum_type->GetByteSize(nullptr));
+              llvm::expectedToOptional(enum_type->GetByteSize(nullptr)));
   }
 }
 
@@ -547,7 +547,7 @@ TEST_F(SymbolFilePDBTests, TestTypedefs) {
     std::string sizeof_var = "sizeof_";
     sizeof_var.append(Typedef);
     EXPECT_EQ(GetGlobalConstantInteger(session, sizeof_var),
-              typedef_type->GetByteSize(nullptr));
+              llvm::expectedToOptional(typedef_type->GetByteSize(nullptr)));
   }
 }