[Lldb-commits] [lldb] [lldb-dap] Fix: disableASLR launch argument not working. (PR #129753)

[Jonas Devlieghere via lldb-commits]

================
@@ -32,12 +32,12 @@ MakeArgv(const llvm::ArrayRef<std::string> &strs) {
 }
 
 static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj,
-                              llvm::StringRef key, lldb::LaunchFlags mask,
-                              bool default_value) {
-  if (GetBoolean(obj, key).value_or(default_value))
-    flags |= mask;
-  else
-    flags &= ~mask;
+                              llvm::StringRef key, lldb::LaunchFlags mask) {
+  if (const auto opt_value = GetBoolean(obj, key))
+    if (opt_value.value())
----------------
JDevlieghere wrote:

Nit: I don't mind using `opt_value.value()` instead of `*opt_value`, but the latter is much more prevalent in llvm & lldb. 
```suggestion
    if (*opt_value)
```

https://github.com/llvm/llvm-project/pull/129753