[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 28 03:54:04 PST 2025
================
@@ -56,13 +58,38 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes the exit status of a debugger.
+struct ExitDescription {
+ int exit_code;
+ std::string description;
+};
+
+struct DebuggerInfo : public LLDBBaseTelemetryInfo {
----------------
labath wrote:
`classof` is implemented as if this class was final
```suggestion
struct DebuggerInfo final: public LLDBBaseTelemetryInfo {
```
If you don't want that, you should change the implementation to accept subclasses
https://github.com/llvm/llvm-project/pull/127696
More information about the lldb-commits
mailing list