[Lldb-commits] [lldb] [lldb-dap] Adding server mode support to lldb-dap VSCode extension. (PR #128957)

[John Harrison via lldb-commits]

ashgti wrote:

> Random question: what happens when the server crashes? Do you get a popup in the UI telling you?

If the server is killed while the debug session is running then the debug session stops. This is the same behavior as today when running not in server mode.

If the server crashes between debug sessions a new one will be spawned on demand. I don't currently alert the user if it shuts down or is killed and I don't have an idle timeout or anything. The server is running under the extension host process and VS Code uses one extension host process per window. That means the server will be around until the window is closed or the user quits VS Code.

As far as server management goes, I don't have any explicit logic for that at the moment, but we could add it in the future. 

Some thoughts:

* The server could shut itself down if the process gets a low memory warning and there are no active clients.
* The server could have an idle timeout and shutdown if there are not active clients after some configurable period.
* The extension could alert the user to unexpected crashes or exits.
* The extension could have commands to manually start / stop the server.

At the moment though, I am keeping this relatively simple.

https://github.com/llvm/llvm-project/pull/128957