[Lldb-commits] [lldb] [lldb-dap] Creating a dedicated Transport class for DAP communication. (PR #128972)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 27 13:50:32 PST 2025


https://github.com/JDevlieghere commented:

This PR feels like it combines 3 different changes:

 - Introducing the Transport class 
 - Using LLDB's logging
 - Introducing the protocol class 

Would it be a lot of work to split this up into 3 separate PRs? If not I'm happy to review everything together here. The Transport changes LGTM and the logging changes look pretty straightforward too, though I'm still worried about the increasing amount of `lldb_private` stuff we're starting to rely on. The largest code change is the introduction of the Protocol class which I'd like to look at in more detail. 



https://github.com/llvm/llvm-project/pull/128972


More information about the lldb-commits mailing list