[Lldb-commits] [lldb] 0865a38 - [lldb] Re-skip PipeTest on windows for now

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 27 04:22:45 PST 2025


Author: Pavel Labath
Date: 2025-02-27T13:22:18+01:00
New Revision: 0865a3872ceb65af2660baf6951a4cee44b65fb1

URL: https://github.com/llvm/llvm-project/commit/0865a3872ceb65af2660baf6951a4cee44b65fb1
DIFF: https://github.com/llvm/llvm-project/commit/0865a3872ceb65af2660baf6951a4cee44b65fb1.diff

LOG: [lldb] Re-skip PipeTest on windows for now

The tests are flaky because the read/write calls return sooner than they
should (and #128719 does not fix them). Skip them until we figure the
best way to fix this.

Added: 
    

Modified: 
    lldb/unittests/Host/PipeTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Host/PipeTest.cpp b/lldb/unittests/Host/PipeTest.cpp
index a3a492648def6..d33797adb7fc3 100644
--- a/lldb/unittests/Host/PipeTest.cpp
+++ b/lldb/unittests/Host/PipeTest.cpp
@@ -59,6 +59,8 @@ TEST_F(PipeTest, OpenAsReader) {
 }
 #endif
 
+// Tests flaky on Windows
+#ifndef _WIN32
 TEST_F(PipeTest, WriteWithTimeout) {
   Pipe pipe;
   ASSERT_THAT_ERROR(pipe.CreateNew(false).ToError(), llvm::Succeeded());
@@ -197,3 +199,4 @@ TEST_F(PipeTest, ReadWithTimeout) {
                        llvm::HasValue(hello_world.size()));
   EXPECT_EQ(llvm::StringRef(buf, hello_world.size()), hello_world);
 }
+#endif /*ifndef _WIN32*/


        


More information about the lldb-commits mailing list