[Lldb-commits] [lldb] [lldb][nfc] Improve duplicated code in unexecuted breakpoint detection (PR #128724)

[Jason Molenda via lldb-commits]

https://github.com/jasonmolenda approved this pull request.

Good idea. I think you need to also update ProcessWindows.cpp?

I'm still a little unsatisfied with my approach of "a thread calls `DetectThreadStoppedAtUnexecutedBP()` and if it turns out it DID execute the breakpoint, then calls `SetThreadHitBreakpointSite()`.  And in fact, if you do it the other way around -- if a method ends up calling `SetThreadHitBreakpointSite()` and then `DetectThreadStoppedAtUnexecutedBP()`, it will lose the fact that it hit the breakpoint and well hit it again on resume, another thing I'm not thrilled about.  But none of that is relevant to this change here.

https://github.com/llvm/llvm-project/pull/128724