[Lldb-commits] [lldb] [lldb] Assorted improvements to the Pipe class (PR #128719)

John Harrison via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 25 09:38:54 PST 2025


================
@@ -55,8 +55,6 @@ TEST_F(PipeTest, OpenAsReader) {
 }
 #endif
 
-// This test is flaky on Windows on Arm.
-#ifndef _WIN32
 TEST_F(PipeTest, WriteWithTimeout) {
----------------
ashgti wrote:

Should we add some tests for the Reader as well?

Something along the lines of:

```
* Read(buf[100], timeout=10s)
* Write("hello world") (under the buffer size)
* AssertEqual(buf, "hello world")

* Read(buf[100], timeout=10s)
* Write("hello world" * 200) (over the buffer size)
* AssertEqual(buf, ("hello world" * 200).slice(0, 100))
* Read(buf[100]) // read the rest
```

https://github.com/llvm/llvm-project/pull/128719


More information about the lldb-commits mailing list