[Lldb-commits] [lldb] [lldb] Avoid Function::GetAddressRange in SymbolFileCTF (PR #128517)
via lldb-commits
lldb-commits at lists.llvm.org
Mon Feb 24 06:23:00 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
<details>
<summary>Changes</summary>
SymbolFileCTF never creates discontinuous functions, so this is technically NFC, but it takes us one step closer to removing the deprecated API.
---
Full diff: https://github.com/llvm/llvm-project/pull/128517.diff
1 Files Affected:
- (modified) lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp (+4-2)
``````````diff
diff --git a/lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp b/lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp
index 0feb927c5c948..0b8862f64ceb8 100644
--- a/lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp
+++ b/lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp
@@ -946,8 +946,10 @@ uint32_t SymbolFileCTF::ResolveSymbolContext(const Address &so_addr,
// Resolve functions.
if (resolve_scope & eSymbolContextFunction) {
for (FunctionSP function_sp : m_functions) {
- if (function_sp->GetAddressRange().ContainsFileAddress(
- so_addr.GetFileAddress())) {
+ if (llvm::any_of(
+ function_sp->GetAddressRanges(), [&](const AddressRange range) {
+ return range.ContainsFileAddress(so_addr.GetFileAddress());
+ })) {
sc.function = function_sp.get();
resolved_flags |= eSymbolContextFunction;
break;
``````````
</details>
https://github.com/llvm/llvm-project/pull/128517
More information about the lldb-commits
mailing list