[Lldb-commits] [lldb] [lldb-dap] Add 'source' references to stack frames without source files. (PR #128268)

via lldb-commits lldb-commits at lists.llvm.org
Sat Feb 22 22:49:47 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r a7d578dcce30345e343cba32beb44e573a753cb0...7d2b0bf8a5dee74b0633a8b8699dcfbb99016606 lldb/test/API/tools/lldb-dap/source/TestDAP_source.py lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py lldb/test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py	2025-02-23 06:46:04.000000 +0000
+++ test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py	2025-02-23 06:49:16.072923 +0000
@@ -218,22 +218,22 @@
             "verify total frames returns a speculative page size",
         )
 
         frame = stackFrames.pop(0)
         frame_name = self.get_dict_value(frame, ["name"])
-        self.assertRegex(frame_name, 'comp')
-        self.assertEqual(self.get_dict_value(frame, ['line']), 14)
-        self.assertNotIn('sourceReference', frame['source'])
+        self.assertRegex(frame_name, "comp")
+        self.assertEqual(self.get_dict_value(frame, ["line"]), 14)
+        self.assertNotIn("sourceReference", frame["source"])
 
         # libc`qsort may not be the first frame below comp, search upwards
         found_qsort = False
         for frame in stackFrames:
-            if 'qsort' not in frame['name']:
+            if "qsort" not in frame["name"]:
                 continue
             found_qsort = True
             self.assertIn("sourceReference", frame["source"])
-        self.assertTrue(found_qsort, 'verify we found the qsort frame')
+        self.assertTrue(found_qsort, "verify we found the qsort frame")
 
     @skipIfWindows
     def test_functionNameWithArgs(self):
         """
         Test that the stack frame without a function name is given its pc in the response.

``````````

</details>


https://github.com/llvm/llvm-project/pull/128268


More information about the lldb-commits mailing list