[Lldb-commits] [lldb] [lldb-dap] Move requests into their own object/file (PR #128262)

[John Harrison via lldb-commits]

================
@@ -0,0 +1,45 @@
+//===-- Request.h ---------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLDB_TOOLS_LLDB_DAP_REQUEST_REQUEST_H
+#define LLDB_TOOLS_LLDB_DAP_REQUEST_REQUEST_H
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/JSON.h"
+
+namespace lldb_dap {
+struct DAP;
+
+class Request {
+public:
+  Request(DAP &dap) : dap(dap) {}
+  virtual ~Request() = default;
+
+  virtual void operator()(const llvm::json::Object &request) = 0;
+
+  static llvm::StringLiteral getName() { return "invalid"; };
+
+  enum LaunchMethod { Launch, Attach, AttachForSuspendedLaunch };
+
+  void SendProcessEvent(LaunchMethod launch_method);
+  void SetSourceMapFromArguments(const llvm::json::Object &arguments);
+
+protected:
+  DAP &dap;
----------------
ashgti wrote:

I've been thinking about the naming convention of the DAP object and I wonder if we should refer to this DAP as a session?

e.g. `DAP &session;`

That kind of represents what this is actually managing in the context of lldb-dap. The `DAP` object is the debug session and is coordinating the `dap.debugger` / `dap.target` with the various requests from the client.

I'm open to other ideas, but its something I've noticed while working on lldb-dap code. 

https://github.com/llvm/llvm-project/pull/128262