[Lldb-commits] [lldb] [lldb] Fix manual CURSES_LIBRARIES tinfo finding (PR #128245)
Daniel Thornburgh via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 21 15:05:26 PST 2025
================
@@ -6,15 +6,24 @@
include(CMakePushCheckState)
-function(lldb_check_curses_tinfo CURSES_LIBRARIES CURSES_HAS_TINFO)
+function(lldb_check_curses_tinfo CURSES_HEADER CURSES_LIBRARIES CURSES_HAS_TINFO)
cmake_reset_check_state()
set(CMAKE_REQUIRED_LIBRARIES "${CURSES_LIBRARIES}")
# acs_map is one of many symbols that are part of tinfo but could
# be bundled in curses.
- check_symbol_exists(acs_map "curses.h" CURSES_HAS_TINFO)
+ check_symbol_exists(acs_map "${CURSES_HEADER}" CURSES_HAS_TINFO)
----------------
mysterymath wrote:
This should still be "curses.h", since this is how curses will be referenced in the LLVM code that uses it. Instead, this should set `CMAKE_REQUIRED_INCLUDES` to the `CURSES_INCLUDE_DIRS` list.
https://github.com/llvm/llvm-project/pull/128245
More information about the lldb-commits
mailing list