[Lldb-commits] [lldb] [lldb] Add terminfo dependency for ncurses support (PR #126810)

[Jordan R AW via lldb-commits]

ajordanr-google wrote:

Turns out `set(CURSES_LIBRARIES "${CURSES_LIBRARIES } ${TINFO_LIBRARIES}")` definitely does NOT work. I think there's some string quoting which gives:

```
ninja -v -j96 -l999 distribution libclang.so                                                                                                                                                                                                                                           
ninja: error: '/usr/lib/libform.so /usr/lib/libtinfo.so', needed by 'lib64/liblldb.so.20.0.0git', missing and no known rule to make it
 * ERROR: sys-devel/llvm-9999::chromiumos failed (compile phase):
 ```
Both `libform.so` and `libtinfo.so` exist at those locations, but obviously the joint path with a space does not.

Using `list(APPEND *_LIBRARIES ${...})` is pretty common elsewhere throughout llvm-project, so I think this is normal. (e.g. mlir/cmake/modules/FindLevelZero.cmake, libunwind/cmake/Modules/HandleLibunwindFlags.cmake, etc.). Also `LINK_LIBS` in `add_lldb_library` is a list, so it should work out.

Everything else I think have working in a new patch. Will upload now.

https://github.com/llvm/llvm-project/pull/126810