[Lldb-commits] [lldb] [lldb][cmake] Use STATUS instead of explicit '--' in message logging (PR #128196)
via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 21 08:43:08 PST 2025
https://github.com/foxtran created https://github.com/llvm/llvm-project/pull/128196
Currently, configuring lldb with cmake with separated stdout and stderr gives some unnecessary output in stderr which happens since message statement is used without `[mode]` (See https://cmake.org/cmake/help/v3.31/command/message.html). This patch adds mode `STATUS` instead of explicit `--` at the beginning of messages.
>From 4683735bef8f43a5e39be6aedffd76c47e43beb2 Mon Sep 17 00:00:00 2001
From: "Igor S. Gerasimov" <i.s.ger at ya.ru>
Date: Fri, 21 Feb 2025 17:33:25 +0100
Subject: [PATCH] Use STATUS instead of explicit '--' in MESSAGE
---
lldb/source/API/CMakeLists.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lldb/source/API/CMakeLists.txt b/lldb/source/API/CMakeLists.txt
index 147b30f3b0026..47b60ef0895a3 100644
--- a/lldb/source/API/CMakeLists.txt
+++ b/lldb/source/API/CMakeLists.txt
@@ -206,23 +206,23 @@ if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows")
# If we're not exporting all symbols, we'll want to explicitly set
# the exported symbols here. This prevents 'log enable --stack ...'
# from working on some systems but limits the liblldb size.
- MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb namespace")
+ MESSAGE(STATUS "Symbols (liblldb): exporting all symbols from the lldb namespace")
add_llvm_symbol_exports(liblldb ${CMAKE_CURRENT_SOURCE_DIR}/liblldb.exports)
elseif (NOT LLDB_EXPORT_ALL_SYMBOLS_EXPORTS_FILE)
# Don't use an explicit export. Instead, tell the linker to export all symbols.
- MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces")
+ MESSAGE(STATUS "Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces")
MESSAGE(WARNING "Private LLDB symbols frequently change and no API stability is guaranteed. "
"Only the SB API is guaranteed to be stable.")
add_llvm_symbol_exports(liblldb ${CMAKE_CURRENT_SOURCE_DIR}/liblldb-private.exports)
else ()
- MESSAGE("-- Symbols (liblldb): exporting all symbols specified in the exports "
+ MESSAGE(STATUS "Symbols (liblldb): exporting all symbols specified in the exports "
" file '${LLDB_EXPORT_ALL_SYMBOLS_EXPORTS_FILE}'")
MESSAGE(WARNING "Private LLDB symbols frequently change and no API stability is guaranteed. "
"Only the SB API is guaranteed to be stable.")
add_llvm_symbol_exports(liblldb "${LLDB_EXPORT_ALL_SYMBOLS_EXPORTS_FILE}")
endif()
elseif (LLDB_EXPORT_ALL_SYMBOLS)
- MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces")
+ MESSAGE(STATUS "Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces")
# Pull out the various lldb libraries linked into liblldb, these will be used
# when looking for symbols to extract. We ignore most plugin libraries here,
More information about the lldb-commits
mailing list