[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

[Jason Molenda via lldb-commits]

================
@@ -5669,6 +5673,10 @@ bool ObjectFileMachO::GetCorefileMainBinaryInfo(addr_t &value,
             type = eBinaryTypeStandalone;
             typestr = "standalone";
             break;
+          case 4:
+            type = eBinaryTypeUserAllImageInfos;
+            typestr = "userland dyld_all_image_infos";
+            break;
----------------
jasonmolenda wrote:

The `typestr` is set to `"unrecognized type"` and will be printed if logging is enabled, but the `type` enum is uninitialized and will also be printed, which could be confusing.  I'll add an initialization.  This method doesn't currently take a Target or Process pointer so I can't print a message to the user asynchronously, it'll require them to enable logging when something is going wrong to find it.

https://github.com/llvm/llvm-project/pull/127156