[Lldb-commits] [lldb] [lldb] Support stepping through C++ thunks (PR #127419)
via lldb-commits
lldb-commits at lists.llvm.org
Mon Feb 17 08:50:38 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 6812fc02fbb81d679f95d5c3e15768ae11e1bad8 b5904f01c64b2c6005f986886ce00ac507172bd2 --extensions cpp,h -- lldb/test/API/lang/cpp/thunk/main.cpp lldb/include/lldb/Target/LanguageRuntime.h lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h lldb/source/Target/ThreadPlanShouldStopHere.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp b/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
index 4885095528..21a5ebe530 100644
--- a/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
+++ b/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
@@ -478,10 +478,12 @@ CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread &thread,
}
bool CPPLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
- llvm::StringRef mangled_name = symbol.GetMangled().GetMangledName().GetStringRef();
+ llvm::StringRef mangled_name =
+ symbol.GetMangled().GetMangledName().GetStringRef();
// Virtual function overriding from a non-virtual base use a "Th" prefix.
// Virtual function overriding from a virtual base must use a "Tv" prefix.
- // Virtual function overriding thunks with covariant returns use a "Tc" prefix.
+ // Virtual function overriding thunks with covariant returns use a "Tc"
+ // prefix.
return mangled_name.starts_with("_ZTh") || mangled_name.starts_with("_ZTv") ||
mangled_name.starts_with("_ZTc");
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/127419
More information about the lldb-commits
mailing list