[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

I wanted to add a new `eBinaryType` enum from the ObjectFile to describe what address is being returned.  But within ProcessMachCore, there was no need to add the distinction between the existing `m_dyld_addr` and the new `m_dyld_all_image_infos_addr`, I did it to keep the meaning of the address clear at this layer, and to make logging more clear.  But ProcessMachCore returns either address to DynamicLoaderMacOSX, and it sniffs for a Mach-O magic number in the first 4 bytes to disambiguate between them already.  I could have ProcessMachCore put either value in `m_dyld_addr` and everything would still work. 

https://github.com/llvm/llvm-project/pull/127156