[Lldb-commits] [lldb] 050933b - [lldb][test] TestCppTemplateArguments.py: adjust expected type

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 13 15:14:06 PST 2025


Author: Michael Buch
Date: 2025-02-13T23:13:46Z
New Revision: 050933b41f8de8498c95dfd0bacb10f3d495d62d

URL: https://github.com/llvm/llvm-project/commit/050933b41f8de8498c95dfd0bacb10f3d495d62d
DIFF: https://github.com/llvm/llvm-project/commit/050933b41f8de8498c95dfd0bacb10f3d495d62d.diff

LOG: [lldb][test] TestCppTemplateArguments.py: adjust expected type

LLVM started emitting the `DW_AT_const_value` for floating point template parameters since https://github.com/llvm/llvm-project/pull/127045. Adjust the expected type in this test. It's still not quite correct but that requires a separate fix in LLDB.

Added: 
    

Modified: 
    lldb/test/API/lang/cpp/template-arguments/TestCppTemplateArguments.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/lang/cpp/template-arguments/TestCppTemplateArguments.py b/lldb/test/API/lang/cpp/template-arguments/TestCppTemplateArguments.py
index f1b3d7a9806fd..c276aae449920 100644
--- a/lldb/test/API/lang/cpp/template-arguments/TestCppTemplateArguments.py
+++ b/lldb/test/API/lang/cpp/template-arguments/TestCppTemplateArguments.py
@@ -63,6 +63,8 @@ def test(self):
 
         # FIXME: type should be Foo<float, 2.0f>
         # FIXME: double/float NTTP parameter values currently not supported.
-        value = self.expect_expr("temp4", result_type="Foo<float, float>")
+        value = self.expect_expr("temp4", result_type="Foo<float, 1073741824>")
         template_param_value = value.GetType().GetTemplateArgumentValue(target, 1)
-        self.assertFalse(template_param_value)
+        self.assertEqual(template_param_value.GetTypeName(), "float")
+        # FIXME: this should return a float
+        self.assertEqual(template_param_value.GetValueAsSigned(), 2)


        


More information about the lldb-commits mailing list