[Lldb-commits] [lldb] [lldb] Remove UtilityTests->Target dep (PR #127060)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 13 05:25:49 PST 2025


https://github.com/labath created https://github.com/llvm/llvm-project/pull/127060

It's completely unnecessary right now, but having it present means that some real unwanted dependencies could sneak in. (This also makes building the test binary much faster.)

>From b5dc90a88c8a0d4182f28ebf4f9844481bd93300 Mon Sep 17 00:00:00 2001
From: Pavel Labath <pavel at labath.sk>
Date: Thu, 13 Feb 2025 14:23:31 +0100
Subject: [PATCH] [lldb] Remove UtilityTests->Target dep

It's completely unnecessary right now, but having it present means that
some real unwanted dependencies could sneak it. (This also makes
building the test binary much faster.)
---
 lldb/unittests/Utility/CMakeLists.txt              | 1 -
 lldb/unittests/Utility/ProcessInstanceInfoTest.cpp | 6 +++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/lldb/unittests/Utility/CMakeLists.txt b/lldb/unittests/Utility/CMakeLists.txt
index 3a73bdc3e9e1a..8d4e2ea35f267 100644
--- a/lldb/unittests/Utility/CMakeLists.txt
+++ b/lldb/unittests/Utility/CMakeLists.txt
@@ -52,7 +52,6 @@ add_lldb_unittest(UtilityTests
   XcodeSDKTest.cpp
 
   LINK_LIBS
-      lldbTarget
       lldbUtility
       lldbUtilityHelpers
       LLVMTestingSupport
diff --git a/lldb/unittests/Utility/ProcessInstanceInfoTest.cpp b/lldb/unittests/Utility/ProcessInstanceInfoTest.cpp
index 3ba35d4efacc1..b653df5fe01a1 100644
--- a/lldb/unittests/Utility/ProcessInstanceInfoTest.cpp
+++ b/lldb/unittests/Utility/ProcessInstanceInfoTest.cpp
@@ -6,7 +6,11 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "lldb/Target/Process.h"
+#include "lldb/Utility/ArchSpec.h"
+#include "lldb/Utility/ProcessInfo.h"
+#include "lldb/Utility/StreamString.h"
+#include "lldb/Utility/UserIDResolver.h"
+#include "llvm/ADT/Twine.h"
 #include "gtest/gtest.h"
 #include <optional>
 



More information about the lldb-commits mailing list