[Lldb-commits] [lldb] [lldb] Synchronize the debugger's stdout and stderr streams (PR #126630)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 13 01:47:00 PST 2025


================
@@ -700,12 +707,14 @@ unsigned char Editline::EndOrAddLineCommand(int ch) {
     }
   }
   MoveCursor(CursorLocation::EditingCursor, CursorLocation::BlockEnd);
-  fprintf(m_output_file, "\n");
+  LockedStreamFile locked_stream = m_output_stream_sp->Lock();
----------------
labath wrote:

And I suspect most/all of these callbacks are called from `GetLine` which means that they could reuse the `locked_stream` member instead of locking it once again.

https://github.com/llvm/llvm-project/pull/126630


More information about the lldb-commits mailing list