[Lldb-commits] [lldb] Define TelemetryVendor plugin. (PR #126588)
Vy Nguyen via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 12 08:19:10 PST 2025
oontvoo wrote:
> This is definitely better than what you had before, but I still think it's more complicated than it needs to be. For one, I'd like to understand why is there a need for separate `TelemetryManager` and `TelemetryConfig` fields. If the downstream implementation is going to be in charge of creating the telemetry manager, why does it need to bother with calling `SetTelemetryConfig`?
Sorry, missed this comment some how.
Yeah, that's a good point. I've removed the new class and just define the static TelemetryManager::getInstance
https://github.com/llvm/llvm-project/pull/126588
More information about the lldb-commits
mailing list