[Lldb-commits] [lldb] Define TelemetryVendor plugin. (PR #126588)

[Pavel Labath via lldb-commits]

================
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h -------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+#ifdef LLDB_BUILD_TELEMETRY
+
+#ifndef LLDB_CORE_TELEMETRYVENDOR_H
+#define LLDB_CORE_TELEMETRYVENDOR_H
+
+#include "lldb/Core/PluginInterface.h"
+#include "lldb/Core/Telemetry.h"
+#include "llvm/Telemetry/Telemetry.h"
+
+#include <memory>
+
+namespace lldb_private {
+
+class TelemetryVendor : public PluginInterface {
+public:
+  TelemetryVendor() = default;
+
+  llvm::StringRef GetPluginName() override;
----------------
labath wrote:

Yes, but `TelemetryVendor::GetTelemetryManager` is a static (non-member) function, which means this class doesn't need to be instantiatable, which means that you don't need to define/override the `GetPluginName` function. Most, if not all of our base classes for plugin hierarchies are abstract classes.

https://github.com/llvm/llvm-project/pull/126588