[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors and extend watchpoint numbers (PR #126020)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett requested changes to this pull request.

I see that the basics of this were added 2 years ago - https://github.com/torvalds/linux/commit/1a69f7a161a78aead07cd4b811d796950e892fa4.

So I assume the build error here is not that NT_LOONGARCH_HW_BREAK is not defined, it's that user_watch_state got redefined?

Please explain all this in the PR *description*. GitHub does not use the contents of the commit messages for the final commit. Link to kernel commits as well, that will be easier than writing out the same justifications again.

Also include something in the title so it's like "Fix build errors with user_watch_v2". If you need to find this commit again, that will help you a lot.

I'd like to know what your intent is with supporting older kernels, if at all. Given that this new structure is not the same size as the other one, or is it? A `pad` was added but perhaps that just made the existing compiler padding explicit?

(I don't care if you do support older kernels or not, but let's get the intent documented)

https://github.com/llvm/llvm-project/pull/126020